Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enableScopePersistence option #3218

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Feb 22, 2024

📜 Description

For now PersistingScopeObserver is used only for ANRv2, but it's generic enough that we can use it for other features (e.g. to address #547), hence we're introducing a new flag to disable scope persistence separately.

We should also think how to improve its performance see #3168

💡 Motivation and Context

Part of getsentry/sentry-unity#1555

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Feb 22, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 376.58 ms 430.94 ms 54.36 ms
Size 1.70 MiB 2.28 MiB 587.91 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4bf95dd 345.96 ms 414.24 ms 68.28 ms
95a98b5 380.06 ms 453.56 ms 73.50 ms
2465853 400.64 ms 465.47 ms 64.83 ms
7ab32b6 373.62 ms 480.61 ms 106.99 ms
2fad834 390.07 ms 470.80 ms 80.73 ms
1f3652d 361.62 ms 424.76 ms 63.14 ms
937879e 400.98 ms 482.84 ms 81.86 ms
4e29063 376.38 ms 390.98 ms 14.60 ms
4e260b3 388.40 ms 468.98 ms 80.58 ms
86f0096 368.63 ms 446.92 ms 78.29 ms

App size

Revision Plain With Sentry Diff
4bf95dd 1.72 MiB 2.29 MiB 576.40 KiB
95a98b5 1.70 MiB 2.27 MiB 586.31 KiB
2465853 1.70 MiB 2.27 MiB 583.82 KiB
7ab32b6 1.70 MiB 2.27 MiB 584.63 KiB
2fad834 1.72 MiB 2.29 MiB 577.53 KiB
1f3652d 1.72 MiB 2.27 MiB 554.95 KiB
937879e 1.72 MiB 2.27 MiB 558.42 KiB
4e29063 1.72 MiB 2.29 MiB 578.38 KiB
4e260b3 1.72 MiB 2.27 MiB 554.95 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB

Previous results on branch: rz/feat/scope-persistence-option

Startup times

Revision Plain With Sentry Diff
d43591d 367.04 ms 451.84 ms 84.80 ms
b0eb9b4 402.20 ms 481.29 ms 79.09 ms

App size

Revision Plain With Sentry Diff
d43591d 1.70 MiB 2.28 MiB 587.91 KiB
b0eb9b4 1.70 MiB 2.28 MiB 587.88 KiB

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io>
@romtsn romtsn enabled auto-merge (squash) February 22, 2024 16:07
@romtsn romtsn merged commit 56f2a8a into main Feb 22, 2024
24 checks passed
@romtsn romtsn deleted the rz/feat/scope-persistence-option branch February 22, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants