-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for measurements at span level #3219
Conversation
spans forward measurements to transaction
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Add support for measurements at span level ([#3219](https://github.com/getsentry/sentry-java/pull/3219)) If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0810952 | 364.51 ms | 468.08 ms | 103.57 ms |
2fad834 | 390.07 ms | 470.80 ms | 80.73 ms |
2465853 | 422.61 ms | 491.20 ms | 68.58 ms |
8ff8fd0 | 432.77 ms | 495.18 ms | 62.41 ms |
2465853 | 400.64 ms | 465.47 ms | 64.83 ms |
5e04ee8 | 365.26 ms | 448.49 ms | 83.23 ms |
c554ca2 | 368.52 ms | 430.74 ms | 62.22 ms |
4e29063 | 384.14 ms | 447.74 ms | 63.60 ms |
0404ea3 | 394.73 ms | 461.79 ms | 67.06 ms |
0404ea3 | 332.47 ms | 401.12 ms | 68.66 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0810952 | 1.72 MiB | 2.27 MiB | 558.21 KiB |
2fad834 | 1.72 MiB | 2.29 MiB | 577.53 KiB |
2465853 | 1.70 MiB | 2.27 MiB | 583.82 KiB |
8ff8fd0 | 1.72 MiB | 2.27 MiB | 558.15 KiB |
2465853 | 1.70 MiB | 2.27 MiB | 583.82 KiB |
5e04ee8 | 1.70 MiB | 2.27 MiB | 584.64 KiB |
c554ca2 | 1.70 MiB | 2.27 MiB | 582.25 KiB |
4e29063 | 1.72 MiB | 2.29 MiB | 578.38 KiB |
0404ea3 | 1.72 MiB | 2.29 MiB | 577.52 KiB |
0404ea3 | 1.72 MiB | 2.29 MiB | 577.52 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, l left a few comments mainly for discussion
sentry-android-core/src/main/java/io/sentry/android/core/PerformanceAndroidEventProcessor.java
Outdated
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.md # sentry-android-core/src/main/java/io/sentry/android/core/PerformanceAndroidEventProcessor.java
…g measurements when coming from the children
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
spans forward measurements to transaction
📜 Description
added measurements to spans
spans forward measurements to transaction
Example transaction
💡 Motivation and Context
Fixes #3180
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps