Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update normalization for Metrics #3332

Merged
merged 9 commits into from
Apr 8, 2024
Merged

Update normalization for Metrics #3332

merged 9 commits into from
Apr 8, 2024

Conversation

markushi
Copy link
Member

@markushi markushi commented Apr 8, 2024

📜 Description

Fixes #3323

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Apr 8, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 7bfdc47

Copy link
Contributor

github-actions bot commented Apr 8, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 408.19 ms 475.78 ms 67.59 ms
Size 1.70 MiB 2.28 MiB 592.02 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
99a51e2 405.11 ms 479.65 ms 74.54 ms
baaf637 375.71 ms 441.58 ms 65.87 ms
95a98b5 379.14 ms 420.80 ms 41.66 ms
8ff8fd0 432.77 ms 495.18 ms 62.41 ms
937879e 400.98 ms 482.84 ms 81.86 ms
4e29063 376.38 ms 390.98 ms 14.60 ms
28c9a83 366.20 ms 433.88 ms 67.67 ms
0bd723b 412.52 ms 496.65 ms 84.13 ms
93a76ca 377.96 ms 447.52 ms 69.56 ms
a537f8a 457.14 ms 514.19 ms 57.05 ms

App size

Revision Plain With Sentry Diff
99a51e2 1.72 MiB 2.29 MiB 576.34 KiB
baaf637 1.72 MiB 2.27 MiB 558.42 KiB
95a98b5 1.70 MiB 2.27 MiB 586.31 KiB
8ff8fd0 1.72 MiB 2.27 MiB 558.15 KiB
937879e 1.72 MiB 2.27 MiB 558.42 KiB
4e29063 1.72 MiB 2.29 MiB 578.38 KiB
28c9a83 1.70 MiB 2.28 MiB 592.00 KiB
0bd723b 1.72 MiB 2.29 MiB 578.09 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
a537f8a 1.70 MiB 2.27 MiB 584.74 KiB

Previous results on branch: feat/metrics-normalization

Startup times

Revision Plain With Sentry Diff
e04d525 372.81 ms 441.31 ms 68.50 ms
e9eb56f 355.69 ms 431.50 ms 75.81 ms
e05c98a 360.46 ms 483.47 ms 123.01 ms

App size

Revision Plain With Sentry Diff
e04d525 1.70 MiB 2.28 MiB 592.02 KiB
e9eb56f 1.70 MiB 2.28 MiB 592.01 KiB
e05c98a 1.70 MiB 2.28 MiB 592.01 KiB

@markushi markushi merged commit e74c05b into main Apr 8, 2024
24 checks passed
@markushi markushi deleted the feat/metrics-normalization branch April 8, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics Normalization
2 participants