-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rate limit to Metrics #3334
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added metric_bucket data category
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
99a51e2 | 405.11 ms | 479.65 ms | 74.54 ms |
baaf637 | 375.71 ms | 441.58 ms | 65.87 ms |
95a98b5 | 379.14 ms | 420.80 ms | 41.66 ms |
8ff8fd0 | 432.77 ms | 495.18 ms | 62.41 ms |
937879e | 400.98 ms | 482.84 ms | 81.86 ms |
4e29063 | 376.38 ms | 390.98 ms | 14.60 ms |
28c9a83 | 366.20 ms | 433.88 ms | 67.67 ms |
0bd723b | 412.52 ms | 496.65 ms | 84.13 ms |
93a76ca | 377.96 ms | 447.52 ms | 69.56 ms |
a537f8a | 457.14 ms | 514.19 ms | 57.05 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
99a51e2 | 1.72 MiB | 2.29 MiB | 576.34 KiB |
baaf637 | 1.72 MiB | 2.27 MiB | 558.42 KiB |
95a98b5 | 1.70 MiB | 2.27 MiB | 586.31 KiB |
8ff8fd0 | 1.72 MiB | 2.27 MiB | 558.15 KiB |
937879e | 1.72 MiB | 2.27 MiB | 558.42 KiB |
4e29063 | 1.72 MiB | 2.29 MiB | 578.38 KiB |
28c9a83 | 1.70 MiB | 2.28 MiB | 592.00 KiB |
0bd723b | 1.72 MiB | 2.29 MiB | 578.09 KiB |
93a76ca | 1.72 MiB | 2.29 MiB | 576.75 KiB |
a537f8a | 1.70 MiB | 2.27 MiB | 584.74 KiB |
Closed
markushi
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, very nice!
renamed words regex to PATTERN_WORD_SNAKE_CASE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
add rate limiting to metrics
added metric_bucket data category
💡 Motivation and Context
Implements #3292
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps