[SR] Introduce capture strategies and handle orientation change for buffer #3357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romtsn
requested review from
adinauer,
stefanosiano and
markushi
as code owners
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4905abb | 394.22 ms | 532.53 ms | 138.31 ms |
| 9576d82 | 413.17 ms | 484.73 ms | 71.56 ms |
| 54ce31d | 356.89 ms | 426.10 ms | 69.21 ms |
| 8e7260f | 367.84 ms | 445.06 ms | 77.22 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4905abb | 1.70 MiB | 2.31 MiB | 627.54 KiB |
| 9576d82 | 1.70 MiB | 2.31 MiB | 627.54 KiB |
| 54ce31d | 1.70 MiB | 2.31 MiB | 627.54 KiB |
| 8e7260f | 1.70 MiB | 2.31 MiB | 627.54 KiB |
markushi
approved these changes
Apr 24, 2024
| } | ||
| } | ||
|
|
||
| protected sealed class ReplaySegment { |
| ) | ||
| if (segment is ReplaySegment.Created) { | ||
| segment.capture(hub) | ||
| currentSegment.getAndIncrement() |
There was a problem hiding this comment.
in case segment creation fails, would you need to increment currentSegment.getAndIncrement() as well?
There was a problem hiding this comment.
no, I think we'd want to try and capture the next time with the same segmentId to avoid gaps. That's a good point for future though, as we could create an rrweb_event indicating the failure and reflect the gap somehow on the playback. I'll add this to ideas list 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
buffermode - we capture segments whenever orientation change happens and keep them in memory until an error happens. We also rotate already captured segments when necessarysessionmode - if a fatal crash happens, we try to capture the current segment to send as complete replay as possible💡 Motivation and Context
Part of getsentry/sentry#63255