Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR] Capture network requests #3380

Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Apr 22, 2024

#skip-changelog

📜 Description

  • Adds RRWebSpanEvent and transforms our breadcrumbs from the scope to these, filtered by the replay segment timespan
  • Had to add start_timestamp/end_timestamp to the http breadcrumbs data bag, because we expect "spans" with start and end time on the frontend side for network requests
  • Small fix for MapObjectReader where nextObjectOrNull would not remove the last entry from stack
  • Adds missing rrweb events to ReplayRecordingTest

image

💡 Motivation and Context

Part of getsentry/sentry#63255

Copy link
Contributor

github-actions bot commented Apr 22, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 379.35 ms 452.93 ms 73.58 ms
Size 1.70 MiB 2.32 MiB 635.59 KiB

Baseline results on branch: rz/feat/session-replay-public-api

Startup times

Revision Plain With Sentry Diff
120668a 363.11 ms 441.60 ms 78.49 ms
a82aaa3 341.67 ms 403.26 ms 61.59 ms

App size

Revision Plain With Sentry Diff
120668a 1.70 MiB 2.32 MiB 633.47 KiB
a82aaa3 1.70 MiB 2.32 MiB 633.46 KiB

Previous results on branch: rz/feat/session-replay-network-requests

Startup times

Revision Plain With Sentry Diff
331bc76 425.82 ms 504.04 ms 78.22 ms

App size

Revision Plain With Sentry Diff
331bc76 1.70 MiB 2.32 MiB 635.66 KiB

@romtsn romtsn changed the title Capture network requests [SR] Capture network requests Apr 23, 2024
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looking good! Left a few minor comments.

Base automatically changed from rz/feat/session-replay-public-api to rz/feat/session-replay April 25, 2024 10:14
@romtsn romtsn merged commit bdd9db5 into rz/feat/session-replay Apr 25, 2024
21 checks passed
@romtsn romtsn deleted the rz/feat/session-replay-network-requests branch April 25, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants