POTEL 11 - Move sampling logic into OTel Sampler #3462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes-merge-2-add-scopes
…ainScopes to rootScopes
…l-2-promote-span-attributes
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- POTEL 11 - Move sampling logic into OTel Sampler ([#3462](https://github.com/getsentry/sentry-java/pull/3462))If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
adinauer
changed the title
lbloder
reviewed
Jun 11, 2024
| } | ||
| // TODO [POTEL] what do we use as fallback here? could happen if misconfigured (i.e. sampler | ||
| // not in place) | ||
| final boolean sampled = samplingDecision != null ? samplingDecision.getSampled() : true; |
There was a problem hiding this comment.
Hmm, should we use otelSpan.getSpanContext().isSampled() as fallback?
...emetry/sentry-opentelemetry-core/src/main/java/io/sentry/opentelemetry/OtelSamplingUtil.java
Show resolved
Hide resolved
...telemetry/sentry-opentelemetry-core/src/main/java/io/sentry/opentelemetry/SentrySampler.java
Show resolved
Hide resolved
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
OTel offers a
Samplerinterface which we now implement to copy sampling decisions or sample using SentryTracesSampler.💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps