Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report dropped spans v8 #3536

Closed
wants to merge 2 commits into from
Closed

Conversation

stefanosiano
Copy link
Member

@stefanosiano stefanosiano commented Jul 1, 2024

📜 Description

added span data category for client reports
added dropped span report when recording lostEnvelopeItem added dropped span report on beforeSend and eventProcessor filtering (SentryClient) and backpressure and sampleRate (Hub)

💡 Motivation and Context

Fixes #3527, already added to main, now it's been merged in v8 branch, too

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

added dropped span report when recording lostEnvelopeItem added dropped span report on beforeSend and eventProcessor filtering (SentryClient) and backpressure and sampleRate (Hub)
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against a3ceebe

@stefanosiano stefanosiano marked this pull request as ready for review July 1, 2024 16:10
@stefanosiano stefanosiano mentioned this pull request Jul 1, 2024
7 tasks
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 405.69 ms 477.58 ms 71.89 ms
Size 1.70 MiB 2.29 MiB 600.00 KiB

@stefanosiano
Copy link
Member Author

did it by merging main into v8

@stefanosiano stefanosiano deleted the feat/report-dropped-spans-v8 branch July 2, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant