Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Android minSdkVersion to 21 #3852

Merged
merged 6 commits into from
Nov 7, 2024
Merged

Bump Android minSdkVersion to 21 #3852

merged 6 commits into from
Nov 7, 2024

Conversation

markushi
Copy link
Member

@markushi markushi commented Nov 6, 2024

📜 Description

21 - everywhere 🪄

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@markushi markushi added this to the 8.0.0 milestone Nov 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 449.44 ms 495.68 ms 46.24 ms
Size 1.65 MiB 2.30 MiB 670.43 KiB

Previous results on branch: chore/bump-min-sdk

Startup times

Revision Plain With Sentry Diff
4c2e769 395.57 ms 445.71 ms 50.13 ms
ea5ded6 430.76 ms 472.29 ms 41.54 ms

App size

Revision Plain With Sentry Diff
4c2e769 1.65 MiB 2.30 MiB 670.20 KiB
ea5ded6 1.65 MiB 2.30 MiB 670.43 KiB

stefanosiano
stefanosiano approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some small additional cleanups

sentry-android-core/src/main/java/io/sentry/android/core/AndroidCpuCollector.java Outdated Show resolved Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/AndroidCpuCollector.java Outdated Show resolved Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/AndroidProfiler.java Outdated Show resolved Hide resolved
...core/src/main/java/io/sentry/android/core/internal/util/AndroidConnectionStatusProvider.java Outdated Show resolved Hide resolved
...core/src/main/java/io/sentry/android/core/internal/util/AndroidConnectionStatusProvider.java Outdated Show resolved Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/NetworkBreadcrumbsIntegration.java Outdated Show resolved Hide resolved
sentry-android-core/src/test/java/io/sentry/android/core/AndroidCpuCollectorTest.kt Outdated Show resolved Hide resolved
@markushi markushi merged commit f11d784 into 8.x.x Nov 7, 2024
23 checks passed
@markushi markushi deleted the chore/bump-min-sdk branch November 7, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanosiano stefanosiano stefanosiano approved these changes

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@markushi @stefanosiano