Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix standalone tomcat jndi issue #3873

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Fix standalone tomcat jndi issue #3873

merged 5 commits into from
Nov 12, 2024

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented Nov 11, 2024

📜 Description

Rename getParsedDsn() to retrieveParsedDsn() to fix issue with JNDI property binding.
This caused getParsedDsn() to be called prematurely and lead to crashes with an emtpy Dsn.

💡 Motivation and Context

Fixes #3825

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Nov 11, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 418.08 ms 448.08 ms 30.00 ms
Size 1.70 MiB 2.35 MiB 668.45 KiB

Previous results on branch: fix/spring-boot-tomcat-dsn

Startup times

Revision Plain With Sentry Diff
661a781 478.29 ms 547.36 ms 69.07 ms
83d6675 435.51 ms 453.35 ms 17.84 ms

App size

Revision Plain With Sentry Diff
661a781 1.70 MiB 2.35 MiB 668.45 KiB
83d6675 1.70 MiB 2.35 MiB 668.45 KiB

@lbloder lbloder marked this pull request as ready for review November 12, 2024 07:41
@adinauer adinauer merged commit 566da76 into main Nov 12, 2024
33 checks passed
@adinauer adinauer deleted the fix/spring-boot-tomcat-dsn branch November 12, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to bind properties under 'sentry.parsed-dsn' to io.sentry.Dsn
2 participants