-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR] Fix crashes and add replay lifecycle management #4135
Conversation
Performance metrics 🚀
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, LGTM!
@romtsn Was this included in the latest react-native release 6.7.0? It looks like it was added, but no new release triggered yet getsentry/sentry-react-native@80e955a |
@simonwh nope, 6.7.0 had been cut before this fix landed, we'll release a new patch version this week! |
📜 Description
FileNotFoundException
by checking for file existence and creating it before writingReplayLifecycle
class which tracks and manages the lifecycle of a running replay:pause
orresume
multiple timesaddOnDrawListener
into a try-catch block as checking it for being alive was still not enough apparently (still got some crashes reported on it)💡 Motivation and Context
Closes getsentry/sentry-react-native#4498
Closes #4133
Closes getsentry/sentry#83352
💚 How did you test it?
Manually + automated
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps