Skip to content

Fix TTFD measurement when API called too early #4297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 15, 2025
Merged

Fix TTFD measurement when API called too early #4297

merged 5 commits into from
Apr 15, 2025

Conversation

stefanosiano
Copy link
Member

📜 Description

Sentry.reportFullyDisplayed now sets a flag if the ttid is not finished.
When the TTID finishes, if the flag is set, the TTFD is finished as well

💡 Motivation and Context

Fixes #3384

💚 How did you test it?

Unit tests

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@stefanosiano
Sentry.reportFullyDisplayed now sets a flag if the ttid is not finished.
2c44f51 
When the TTID finishes, if the flag is set, the TTFD is finished as well
@stefanosiano
updated changelog
4d262fd
@stefanosiano stefanosiano marked this pull request as ready for review March 28, 2025 15:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 420.33 ms 457.47 ms 37.14 ms
Size 1.58 MiB 2.08 MiB 505.69 KiB

Previous results on branch: fix/ttfd-measurement

Startup times

Revision Plain With Sentry Diff
c10e97d 432.29 ms 480.24 ms 47.95 ms

App size

Revision Plain With Sentry Diff
c10e97d 1.58 MiB 2.22 MiB 655.02 KiB

markushi
markushi approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanosiano stefanosiano requested a review from lcian as a code owner April 15, 2025 08:46
@stefanosiano stefanosiano merged commit 32564c8 into main Apr 15, 2025
35 checks passed
@stefanosiano stefanosiano deleted the fix/ttfd-measurement branch April 15, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markushi markushi markushi approved these changes

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@lcian lcian Awaiting requested review from lcian lcian is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overwrite TTFD measurement when API called too early
2 participants
@stefanosiano @markushi