Skip to content

Use lazy task configuration #4399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 14, 2025
Merged

Use lazy task configuration #4399

merged 5 commits into from
May 14, 2025

Conversation

runningcode
Copy link
Contributor

@runningcode runningcode commented May 13, 2025

This reduces the amount of tasks configured.
See this confusing Gradle doc for tasks to avoid and task to not avoid: https://docs.gradle.org/current/userguide/task_configuration_avoidance.html#sec:old_vs_new_configuration_api_overview

Before: 516 Build Scan
After: 158, Build Scan

#skip-changelog

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented May 13, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 421.08 ms 505.80 ms 84.72 ms
Size 1.58 MiB 2.08 MiB 510.51 KiB

Previous results on branch: no/lazy-task

Startup times

Revision Plain With Sentry Diff
2afa7b6 404.02 ms 442.31 ms 38.28 ms
b354483 373.64 ms 423.85 ms 50.21 ms

App size

Revision Plain With Sentry Diff
2afa7b6 1.58 MiB 2.08 MiB 510.52 KiB
b354483 1.58 MiB 2.08 MiB 510.51 KiB

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@runningcode runningcode enabled auto-merge (squash) May 14, 2025 16:25
@runningcode runningcode merged commit 8696c89 into main May 14, 2025
33 checks passed
@runningcode runningcode deleted the no/lazy-task branch May 14, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants