Skip to content

Migrate some test dependencies to version catalogs #4422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2025
Merged

Migrate some test dependencies to version catalogs #4422

merged 2 commits into from
May 20, 2025

Conversation

rbro112
Copy link
Member

@rbro112 rbro112 commented May 20, 2025

📜 Description

Continue adopting version catalog

#skip-changelog

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@runningcode runningcode force-pushed the no/version-catalog-4 branch 2 times, most recently from 29fbfe6 to dc32b65 Compare May 20, 2025 13:56
Base automatically changed from no/version-catalog-4 to main May 20, 2025 14:09
@rbro112 rbro112 force-pushed the ryan/version-catalog-5 branch from b4d0d0a to b59ffdc Compare May 20, 2025 18:52
@github-actions GitHub Actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 400.04 ms 436.85 ms 36.81 ms
Size 1.58 MiB 2.08 MiB 510.83 KiB

@rbro112 rbro112 merged commit f5b4aee into main May 20, 2025
33 checks passed
@rbro112 rbro112 deleted the ryan/version-catalog-5 branch May 20, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runningcode runningcode runningcode approved these changes

@romtsn romtsn romtsn approved these changes

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

@markushi markushi Awaiting requested review from markushi markushi is a code owner

@lcian lcian Awaiting requested review from lcian lcian is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbro112 @runningcode @romtsn