-
-
Notifications
You must be signed in to change notification settings - Fork 459
fix(replay): Do not use recycled screenshots #4790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
romtsn
wants to merge
32
commits into
main
Choose a base branch
from
rz/fix/session-replay-bitmap-crash
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-java into markushi/canvas-approach
sentry-android-replay/src/main/java/io/sentry/android/replay/util/ReplayExecutorService.kt
Show resolved
Hide resolved
sentry-android-replay/src/main/java/io/sentry/android/replay/util/ReplayExecutorService.kt
Show resolved
Hide resolved
Performance metrics 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
recorder.close()
is called from a different thread after we captured the screenshot, but before masking is applied) which resulted in native crashes when initing aCanvas
backed by it. This PR checks for bitmap.isRecycled and recorder being closed before doing anything with the screenshot.ReplayExecutorService
which allows us to abstract away our "safe" way of submitting runnables, but also allows us to override this behaviour in tests in case we want a test to actual fail because of the exception thrown inside runnable.💡 Motivation and Context
Closes getsentry/sentry-react-native#5159
💚 How did you test it?
Manually + automated
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps