Avoid StrictMode warnings (followup) #4809
Conversation
* AndroidEnvelopeCache * Installation.id calls * DeviceInfoUtil updated tests
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
stefanosiano
requested review from
adinauer,
lcian,
markushi and
romtsn
as code owners
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 85d7417 | 347.21 ms | 394.35 ms | 47.15 ms |
| d364ace | 411.72 ms | 430.81 ms | 19.10 ms |
| ee747ae | 396.82 ms | 441.67 ms | 44.86 ms |
| bdbe1f4 | 380.66 ms | 464.44 ms | 83.78 ms |
| c8125f3 | 383.82 ms | 441.66 ms | 57.84 ms |
| ee747ae | 386.94 ms | 431.43 ms | 44.49 ms |
| 806307f | 357.85 ms | 424.64 ms | 66.79 ms |
| ee747ae | 554.98 ms | 611.50 ms | 56.52 ms |
| b3d8889 | 371.69 ms | 432.96 ms | 61.26 ms |
| 7314dbe | 437.83 ms | 505.64 ms | 67.81 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 85d7417 | 1.58 MiB | 2.10 MiB | 533.44 KiB |
| d364ace | 1.58 MiB | 2.11 MiB | 539.75 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| bdbe1f4 | 1.58 MiB | 2.11 MiB | 538.88 KiB |
| c8125f3 | 1.58 MiB | 2.10 MiB | 532.32 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 806307f | 1.58 MiB | 2.10 MiB | 533.42 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| b3d8889 | 1.58 MiB | 2.10 MiB | 535.06 KiB |
| 7314dbe | 1.58 MiB | 2.10 MiB | 533.45 KiB |
Previous results on branch: stefanosiano/fix/strict-mode-followup
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8698d00 | 425.12 ms | 463.00 ms | 37.88 ms |
| c130ecc | 359.74 ms | 403.84 ms | 44.10 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8698d00 | 1.58 MiB | 2.11 MiB | 539.89 KiB |
| c130ecc | 1.58 MiB | 2.11 MiB | 539.89 KiB |
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
sentry/src/test/java/io/sentry/util/runtime/NeutralRuntimeManagerTest.kt
Show resolved
Hide resolved
...android-core/src/test/java/io/sentry/android/core/internal/util/AndroidRuntimeManagerTest.kt
Outdated
Show resolved
Hide resolved
| device.setExternalStorageSize(getTotalExternalStorage(externalStorageStat)); | ||
| device.setExternalFreeStorage(getUnusedExternalStorage(externalStorageStat)); | ||
| } | ||
| options |
There was a problem hiding this comment.
We do this to have a base of 0 strictmode warnings, right? I'm just wondering if we should keep this as-is, as the collection of these attributes can be turned off via settings anyway.
There was a problem hiding this comment.
yeah, but the default is enabled, so i guess it makes more sense for the user to have no strictMode warnings "by default"
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
…lowup' into stefanosiano/fix/strict-mode-followup
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
3 participants
📜 Description
added AndroidRuntimeManager.runWithRelaxedPolicy to
#skip-changelog
💡 Motivation and Context
Follwup of #4724
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps