fix: Always delete files when sourcemaps.filesToDeleteAfterUpload is set
#547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fml |
AbhiPrasad
approved these changes
Jun 19, 2024
This was referenced Aug 28, 2024
This was referenced Sep 5, 2024
This was referenced Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only delete files when the debug ID upload was initiated. This is extremely confusing if you use the legacy upload or didn't upload at all - for example when not providing an auth token.
With this we will always run deletion when
sourcemaps.filesToDeleteAfterUploadis set, and up to two additional times, after the debug ID upload and the legacy upload have completed.