cleanup

getsentry · Sep 27, 2024 · 1886c87 · 1886c87
1 parent 22124e0
commit 1886c87
Show file tree

Hide file tree

Showing 7 changed files with 4 additions and 26 deletions.
diff --git a/dev-packages/e2e-tests/test-applications/sveltekit-2-twp/README.md b/dev-packages/e2e-tests/test-applications/sveltekit-2-twp/README.md
@@ -1,3 +1,5 @@
-# SvelteKit 2 TwP
+# Tracing Without Performance E2E test app
 
 E2E test app for testing Tracing Without Performance in a (SvelteKit) meta framework scenario
+
+Add tests to this app that specifically test TwP in meta frameworks.
diff --git a/dev-packages/e2e-tests/test-applications/sveltekit-2-twp/src/hooks.client.ts b/dev-packages/e2e-tests/test-applications/sveltekit-2-twp/src/hooks.client.ts
@@ -8,10 +8,6 @@ Sentry.init({
   dsn: env.PUBLIC_E2E_TEST_DSN,
   release: '1.0.0',
   tunnel: `http://localhost:3031/`, // proxy server
-  beforeSend(event) {
-    console.log('beforeSend', event.contexts?.trace?.trace_id);
-    return event;
-  },
 });
 
 const myErrorHandler = ({ error, event }: any) => {

diff --git a/dev-packages/e2e-tests/test-applications/sveltekit-2-twp/src/hooks.server.ts b/dev-packages/e2e-tests/test-applications/sveltekit-2-twp/src/hooks.server.ts
@@ -5,10 +5,6 @@ Sentry.init({
   environment: 'qa', // dynamic sampling bias to keep transactions
   dsn: E2E_TEST_DSN,
   tunnel: `http://localhost:3031/`, // proxy server
-  beforeSend(event) {
-    console.log('beforeSend', event.contexts?.trace?.trace_id);
-    return event;
-  },
 });
 
 // not logging anything to console to avoid noise in the test output

diff --git a/dev-packages/e2e-tests/test-applications/sveltekit-2-twp/src/routes/+layout.svelte b/dev-packages/e2e-tests/test-applications/sveltekit-2-twp/src/routes/+layout.svelte
@@ -1,14 +1,3 @@
-<script lang="ts">
-  import { onMount } from "svelte";
-
-  onMount(() => {
-    // Indicate that the SvelteKit app was hydrated
-    document.body.classList.add("hydrated");
-  });
-
-
-</script>
-
 <h1>Sveltekit E2E Test app</h1>
 <div data-sveltekit-preload-data="off">
   <slot></slot>

diff --git a/dev-packages/e2e-tests/test-applications/sveltekit-2-twp/src/routes/errors/+page.server.ts b/dev-packages/e2e-tests/test-applications/sveltekit-2-twp/src/routes/errors/+page.server.ts
@@ -2,9 +2,6 @@ import * as Sentry from '@sentry/sveltekit';
 
 export const load = async ({ url }) => {
   if (!url.search) {
-    console.log('traceData: ', Sentry.getTraceData());
-    console.log('spanToTrace', Sentry.spanToTraceHeader(Sentry.getActiveSpan()!));
-    console.log('activeSpan', Sentry.getActiveSpan());
     Sentry.captureException(new Error('No search query provided'));
     return {
       error: 'No search query provided',

diff --git a/dev-packages/e2e-tests/test-applications/sveltekit-2-twp/src/routes/errors/+page.svelte b/dev-packages/e2e-tests/test-applications/sveltekit-2-twp/src/routes/errors/+page.svelte
@@ -1,13 +1,10 @@
 <script lang="ts">
   import { onMount } from 'svelte';
-  import * as Sentry from '@sentry/sveltekit';
 
   export let data;
 
   onMount(() => {
-
       if (data.error) {
-        console.log(Sentry.getTraceData());
         throw new Error('Client Error');
       }
   });

diff --git a/dev-packages/e2e-tests/test-applications/sveltekit-2-twp/tests/errors.test.ts b/dev-packages/e2e-tests/test-applications/sveltekit-2-twp/tests/errors.test.ts
@@ -1,5 +1,6 @@
 import { expect, test } from '@playwright/test';
 import { waitForError } from '@sentry-internal/test-utils';
+
 test('errors on frontend and backend are connected by the same trace', async ({ page }) => {
   const clientErrorPromise = waitForError('sveltekit-2-twp', evt => {
     return evt.exception?.values?.[0].value === 'Client Error';