Skip to content

Commit

Permalink
replace jest eslint rules
Browse files Browse the repository at this point in the history
  • Loading branch information
Lms24 committed Aug 27, 2024
1 parent 81d6f3b commit 203049b
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 20 deletions.
2 changes: 1 addition & 1 deletion packages/core/test/lib/transports/offline.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ describe('makeOfflineTransport', () => {
START_DELAY + 2_000,
);

// eslint-disable-next-line jest/no-disabled-tests
// eslint-disable-next-line @sentry-internal/sdk/no-skipped-tests
it.skip(
'Follows the Retry-After header',
async () => {
Expand Down
18 changes: 0 additions & 18 deletions packages/eslint-config-sdk/src/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -188,24 +188,6 @@ module.exports = {
'@sentry-internal/sdk/no-skipped-tests': 'error',
},
},
{
// Configuration only for test files (this won't apply to utils or other files in test directories)
plugins: ['jest'],
env: {
jest: true,
},
files: ['test.ts', '*.test.ts', '*.test.tsx', '*.test.js', '*.test.jsx'],
rules: {
// Prevent permanent usage of `it.only`, `fit`, `test.only` etc
// We want to avoid debugging leftovers making their way into the codebase
'jest/no-focused-tests': 'error',

// Prevent permanent usage of `it.skip`, `xit`, `test.skip` etc
// We want to avoid debugging leftovers making their way into the codebase
// If there's a good reason to skip a test (e.g. bad flakiness), just add an ignore comment
'jest/no-disabled-tests': 'error',
},
},
{
// Configuration for config files like webpack/rollup
files: ['*.config.js', '*.config.mjs'],
Expand Down
2 changes: 1 addition & 1 deletion packages/profiling-node/test/cpu_profiler.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ describe('Profiler bindings', () => {
expect(profile?.measurements?.['memory_footprint']?.values.length).toBeLessThanOrEqual(300);
});

// eslint-disable-next-line jest/no-disabled-tests
// eslint-disable-next-line @sentry-internal/sdk/no-skipped-tests
it.skip('includes deopt reason', async () => {
// https://github.com/petkaantonov/bluebird/wiki/Optimization-killers#52-the-object-being-iterated-is-not-a-simple-enumerable
function iterateOverLargeHashTable() {
Expand Down

0 comments on commit 203049b

Please sign in to comment.