feat(opentelemetry): Export getRequestSpanData (#11508)

Instead of exporting `_INTERNAL` here, it's OK IMHO to export this. The API is stable enough.
getsentry · Apr 9, 2024 · 4759d4c · 4759d4c
1 parent cdf20be
commit 4759d4c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 15 deletions.
diff --git a/packages/node/src/integrations/http.ts b/packages/node/src/integrations/http.ts
@@ -14,7 +14,7 @@ import {
  setCapturedScopesOnSpan,
  spanToJSON,
 } from '@sentry/core';
-import { _INTERNAL, getClient, getSpanKind } from '@sentry/opentelemetry';
+import { getClient, getRequestSpanData, getSpanKind } from '@sentry/opentelemetry';
 import type { IntegrationFn } from '@sentry/types';
 
 import { stripUrlQueryAndFragment } from '@sentry/utils';
@@ -162,7 +162,7 @@ function _addRequestBreadcrumb(span: Span, response: HTTPModuleRequestIncomingMe
  return;
  }
 
- const data = _INTERNAL.getRequestSpanData(span);
+ const data = getRequestSpanData(span);
  addBreadcrumb(
  {
  category: 'http',

diff --git a/packages/node/src/integrations/node-fetch.ts b/packages/node/src/integrations/node-fetch.ts
@@ -3,7 +3,7 @@ import { SpanKind } from '@opentelemetry/api';
 import type { Instrumentation } from '@opentelemetry/instrumentation';
 import { registerInstrumentations } from '@opentelemetry/instrumentation';
 import { addBreadcrumb, defineIntegration } from '@sentry/core';
-import { _INTERNAL, getSpanKind } from '@sentry/opentelemetry';
+import { getRequestSpanData, getSpanKind } from '@sentry/opentelemetry';
 import type { IntegrationFn } from '@sentry/types';
 import { logger } from '@sentry/utils';
 import { DEBUG_BUILD } from '../debug-build';
@@ -88,7 +88,7 @@ function _addRequestBreadcrumb(span: Span): void {
  return;
  }
 
- const data = _INTERNAL.getRequestSpanData(span);
+ const data = getRequestSpanData(span);
  addBreadcrumb({
  category: 'http',
  data: {

diff --git a/packages/opentelemetry/src/index.ts b/packages/opentelemetry/src/index.ts
@@ -1,4 +1,4 @@
-import { getRequestSpanData } from './utils/getRequestSpanData';
+export { getRequestSpanData } from './utils/getRequestSpanData';
 
 export type { OpenTelemetryClient } from './types';
 export { wrapClientClass } from './custom/client';
@@ -39,13 +39,3 @@ export { openTelemetrySetupCheck } from './utils/setupCheck';
 
 // Legacy
 export { getClient } from '@sentry/core';
-
-/**
- * The following internal utils are not considered public API and are subject to change.
- * @hidden
- */
-const _INTERNAL = {
- getRequestSpanData,
-} as const;
-
-export { _INTERNAL };