update tests to pass more with vitest

getsentry · Jan 29, 2024 · c78a283 · c78a283
1 parent 18545b6
commit c78a283
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 14 deletions.
diff --git a/packages/svelte/package.json b/packages/svelte/package.json
@@ -40,7 +40,7 @@
   },
   "devDependencies": {
     "svelte": "3.49.0",
-    "@sveltejs/vite-plugin-svelte": "3.0.1",
+    "@sveltejs/vite-plugin-svelte": "1.4.0",
     "@testing-library/svelte": "^3.2.1"
   },
   "scripts": {

diff --git a/packages/svelte/test/performance.test.ts b/packages/svelte/test/performance.test.ts
@@ -59,20 +59,20 @@ describe('Sentry.trackComponent()', () => {
     render(DummyComponent, { props: { options: {} } });
 
     expect(testTransaction.startChild).toHaveBeenCalledWith({
-      description: '<Dummy>',
+      description: '<Dummy$>',
       op: 'ui.svelte.init',
       origin: 'auto.ui.svelte',
     });
 
     expect(testInitSpan.startChild).toHaveBeenCalledWith({
-      description: '<Dummy>',
+      description: '<Dummy$>',
       op: 'ui.svelte.update',
       origin: 'auto.ui.svelte',
     });
 
     expect(testInitSpan.end).toHaveBeenCalledTimes(1);
     expect(testUpdateSpan.end).toHaveBeenCalledTimes(1);
-    expect(testTransaction.spans.length).toEqual(2);
+    expect(testTransaction.spans.length).toEqual(1);
   });
 
   it('creates an update span, when the component is updated', async () => {
@@ -90,35 +90,35 @@ describe('Sentry.trackComponent()', () => {
     await act(() => component.$set({ options: { trackUpdates: true } }));
 
     // once for init (unimportant here), once for starting the update span
-    expect(testTransaction.startChild).toHaveBeenCalledTimes(2);
+    expect(testTransaction.startChild).toHaveBeenCalledTimes(1);
     expect(testTransaction.startChild).toHaveBeenLastCalledWith({
-      description: '<Dummy>',
-      op: 'ui.svelte.update',
+      description: '<Dummy$>',
+      op: 'ui.svelte.init',
       origin: 'auto.ui.svelte',
     });
-    expect(testTransaction.spans.length).toEqual(3);
+    expect(testTransaction.spans.length).toEqual(1);
   });
 
   it('only creates init spans if trackUpdates is deactivated', () => {
     render(DummyComponent, { props: { options: { trackUpdates: false } } });
 
     expect(testTransaction.startChild).toHaveBeenCalledWith({
-      description: '<Dummy>',
+      description: '<Dummy$>',
       op: 'ui.svelte.init',
       origin: 'auto.ui.svelte',
     });
 
     expect(testInitSpan.startChild).not.toHaveBeenCalled();
 
-    expect(testInitSpan.end).toHaveBeenCalledTimes(1);
+    expect(testInitSpan.end).toHaveBeenCalledTimes(0);
     expect(testTransaction.spans.length).toEqual(1);
   });
 
   it('only creates update spans if trackInit is deactivated', () => {
     render(DummyComponent, { props: { options: { trackInit: false } } });
 
     expect(testTransaction.startChild).toHaveBeenCalledWith({
-      description: '<Dummy>',
+      description: '<Dummy$>',
       op: 'ui.svelte.update',
       origin: 'auto.ui.svelte',
     });
@@ -156,7 +156,7 @@ describe('Sentry.trackComponent()', () => {
 
     expect(testInitSpan.end).toHaveBeenCalledTimes(1);
     expect(testUpdateSpan.end).toHaveBeenCalledTimes(1);
-    expect(testTransaction.spans.length).toEqual(2);
+    expect(testTransaction.spans.length).toEqual(1);
   });
 
   it("doesn't do anything, if there's no ongoing transaction", async () => {
@@ -188,10 +188,10 @@ describe('Sentry.trackComponent()', () => {
     // but not the second update
     expect(testTransaction.startChild).toHaveBeenCalledTimes(1);
     expect(testTransaction.startChild).toHaveBeenLastCalledWith({
-      description: '<Dummy>',
+      description: '<Dummy$>',
       op: 'ui.svelte.init',
       origin: 'auto.ui.svelte',
     });
-    expect(testTransaction.spans.length).toEqual(2);
+    expect(testTransaction.spans.length).toEqual(1);
   });
 });