fix(replay): Fix hasCheckout handling (#8782)

1. Make sure it is correctly kept when doing the compression worker switchover 2. Make sure it is correctly set for `session` recordings
getsentry · Aug 10, 2023 · da1b592 · da1b592
1 parent dd6273e
commit da1b592
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/packages/replay/src/eventBuffer/EventBufferProxy.ts b/packages/replay/src/eventBuffer/EventBufferProxy.ts
@@ -99,13 +99,15 @@ export class EventBufferProxy implements EventBuffer {
 
   /** Switch the used buffer to the compression worker. */
   private async _switchToCompressionWorker(): Promise<void> {
-    const { events } = this._fallback;
+    const { events, hasCheckout } = this._fallback;
 
     const addEventPromises: Promise<void>[] = [];
     for (const event of events) {
       addEventPromises.push(this._compression.addEvent(event));
     }
 
+    this._compression.hasCheckout = hasCheckout;
+
     // We switch over to the new buffer immediately - any further events will be added
     // after the previously buffered ones
     this._used = this._compression;

diff --git a/packages/replay/src/util/addEvent.ts b/packages/replay/src/util/addEvent.ts
@@ -52,6 +52,9 @@ export async function addEvent(
   try {
     if (isCheckout && replay.recordingMode === 'buffer') {
       replay.eventBuffer.clear();
+    }
+
+    if (isCheckout) {
       replay.eventBuffer.hasCheckout = true;
     }