Avoid recursion when using the console plugin

Fixes #320 #364 #369

Author: mattrobenolt

plugins/console.js

@@ -25,9 +25,9 @@ var logForGivenLevel = function(level) {
         if (originalConsoleLevel) {
             // IE9 doesn't allow calling apply on console functions directly
             // See: https://stackoverflow.com/questions/5472938/does-ie9-support-console-log-and-is-it-a-real-function#answer-5473193
-             Function.prototype.bind
-                 .call(originalConsoleLevel, originalConsole)
-                 .apply(originalConsole, args);
+            Function.prototype.bind
+                .call(originalConsoleLevel, originalConsole)
+                .apply(originalConsole, args);
         }
     };
 };
@@ -39,5 +39,7 @@ while(level) {
 }
 // export
 window.console = console;
+// keep a reference to the original console so we don't recurse on ourselves
+window._Raven_original_console = originalConsole;
 
 }(window, window.Raven, window.console || {}));

src/raven.js

@@ -851,9 +851,13 @@ function uuid4() {
 
 function logDebug(level) {
     if (window.console && console[level] && Raven.debug) {
+        // If `window._Raven_original_console exists, that means
+        // we've already patched `console`. So we want to avoid recursion
+        // and utilize the real, original one.
+        var originalConsole = window._Raven_original_console || console;
         // _slice is coming from vendor/TraceKit/tracekit.js
         // so it's accessible globally
-        console[level].apply(console, _slice.call(arguments, 1));
+        originalConsole[level].apply(originalConsole, _slice.call(arguments, 1));
     }
 }
 

test/raven.test.js

@@ -342,6 +342,17 @@ describe('globals', function() {
             this.sinon.stub(console, level);
             logDebug(level, message, {}, 'foo');
         });
+
+        it('should write to window._Raven_original_console when patched', function() {
+            Raven.debug = true;
+            this.sinon.stub(console);
+            window._Raven_original_console = {'error': function(){}};
+            this.sinon.stub(window._Raven_original_console, level);
+            logDebug(level, message);
+            assert.isTrue(window._Raven_original_console[level].called);
+            assert.isFalse(console[level].called);
+            delete window._Raven_original_console;
+        });
     });
 
     describe('setAuthQueryString', function() {