Change logLevel in isSetup from error to warn. Error stops processin… #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and perhaps should be prohibited by logDebug. Fixes functionnal proble with the merge of getsentry#364
mattrobenolt
added a commit
that referenced
this pull request
Aug 19, 2015
mattrobenolt
added a commit
that referenced
this pull request
Aug 19, 2015
|
Ok, I confirm that #370 fixes the root cause for me, so this pull request is obsolete. Thanks @mattrobenolt, @benvinegar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g, and perhaps should be prohibited by logDebug. Fixes functional problem with the merge of #364
@benvinegar Can you take a look. I don't know why console.error stops processing. It generates a backtrace, maybe that's the reason. Replacing it with a console.warn everything works fine.