Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logLevel in isSetup from error to warn. Error stops processin… #369

Closed
wants to merge 1 commit into from
Closed

Change logLevel in isSetup from error to warn. Error stops processin… #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/raven.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,7 +787,7 @@ function isSetup() {
if (!hasJSON) return false; // needs JSON support
if (!globalServer) {
if (!ravenNotConfiguredError)
logDebug('error', 'Error: Raven has not been configured.');
logDebug('warn', 'Warning: Raven has not been configured.');
ravenNotConfiguredError = true;
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion test/raven.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ describe('globals', function() {
globalServer = undefined;
isSetup();
isSetup();
assert.isTrue(window.logDebug.calledWith('error', 'Error: Raven has not been configured.'))
assert.isTrue(window.logDebug.calledWith('warn', 'Warning: Raven has not been configured.'))
assert.isTrue(window.logDebug.calledOnce);
});
});
Expand Down