-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot read properties of undefined (reading 'toLowerCase') on mousemove #10292
Comments
Hi @RoyvanEmpel thanks for writing in! Looks like rrweb doesn't guard this properly (although according to the type definitions the name property should always be a string but 🤷). I opened getsentry/rrweb#160 which probably fixes the errors but I'll let the Replay team review this first (I might be missing some context here). cc @billyvg @mydea |
Alright, will check if it's fixed when getsentry/rrweb#160 gets to a live version! |
… attributes (#160) Probably fixes getsentry/sentry-javascript#10292 Not sure how `attr.name` could be undefined here but according to the issue, it happens and we should probably guard adding the attribute.
… attributes (#160) Probably fixes getsentry/sentry-javascript#10292 Not sure how `attr.name` could be undefined here but according to the issue, it happens and we should probably guard adding the attribute.
Hi @Lms24 when can we expect to see this in the sentry/vue package? We updates to the latest versions today for both sentry-selfhosted and sentry-vue and we are still recieving the 'toLowerCase' errors when enabeling the replays. |
Hey @RoyvanEmpel we bumped to rrweb 2.10.0 a couple of days ago. With the next SDK release (7.100.0) you should receive the fix. Expect it to be released early next week. Sorry for the trouble! |
… attributes (#160) Probably fixes getsentry/sentry-javascript#10292 Not sure how `attr.name` could be undefined here but according to the issue, it happens and we should probably guard adding the attribute.
Is there an existing issue for this?
How do you use Sentry?
Self-hosted/on-premise
Which SDK are you using?
@sentry/vue
SDK Version
7.94.1
Framework Version
Vue 3.4.15
Link to Sentry event
https://sentry.aniday.io/share/issue/94391781baa34b2b9a3d40d3d21a70c8/
SDK Setup
Steps to Reproduce
I am having a problem with the session replays in sentry.
We recently setup sentry and sometimes when opening different pages in our system a lot of "toLowerCase" errors are displayed in the console. The errors are triggered by a mouse move event from sentry causing the clients PC to become very laggy and slow.
Atm our sentry is loaded into VueJS and for the time beeing vuejs is only a part of our total system.
Since the rest of the system loads pages using Ajax and the vuejs index gets loaded anywere, sentry is loaded by default
It may also have something to do with the cloudflare rocket-loader as i saw that come by once in sentry's errors.
Expected Result
In this case the expected result would be that it doesn't spam the user with errors on the mouse event. And not slow down thier PC.
For now as a temporary fix in our production we have had to disabled the sentry replays.
Actual Result
These are a few screenshots of it happening in the console:
The text was updated successfully, but these errors were encountered: