-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Open
Labels
Description
Followup to #11169
In the logic where we set a span status based on HTTP_STATUS_CODE or RPC_GRPC_STATUS code, there are two inconsistencies with the spec (https://opentelemetry.io/docs/specs/semconv/rpc/grpc/):
- We assume the GRPC status codes are stored as
string, while the spec says the GRPC status codes are stored asint. - We set the status to
ERRORfor all of the status codes, while the spec says we should set the status toERRORorUNSETbased on whether the span is a client or a server span.