-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring back lastEventId
API
#11951
Comments
Also ref: getsentry/sentry-python#3057 (comment) |
Python PR using isolationScope: getsentry/sentry-python#3064 |
…2022) Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
The `lastEventId` api will be brought back in v8 in the near future.
The `lastEventId` api will be brought back in v8 in the near future.
…2022) Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@Lms24 we are not seeing this reintroduced in |
@thespacemanatee which SDK are you using? |
@Lms24 We are using https://github.com/getsentry/sentry-react-native/releases/tag/6.3.0 which depends on |
Problem Statement
The king is dead, long live the king...
We removed
lastEventId
in #10585 due to several shortcomings of this API:captureEvent
, before processing and sending the event. Meaning, if users or our event processors dropped the event,lastEventId
would return an id of an event that wasn't ever sent from the SDK.Hub
was used, it could potentially bleed through requests/"leak" an event id of another request if there was no proper request isolation set up.Solution Brainstorm
In an effort to minimize friction we should bring back this API:
Tasks
lastEventId
on isolation scope (#11951) #12022eventId
optional and uselastEventId
in report dialog #12029lastEventId
deprecation warnings (#11951) #12042lastEventId
removal (v8) and deprecation (v7) in migration docs sentry-docs#10127The text was updated successfully, but these errors were encountered: