Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INP spans sent via tunnel fail because they are missing the expected "dsn" property #12094

Closed
3 tasks done
mfb opened this issue May 17, 2024 · 1 comment · Fixed by #12096
Closed
3 tasks done

INP spans sent via tunnel fail because they are missing the expected "dsn" property #12094

mfb opened this issue May 17, 2024 · 1 comment · Fixed by #12096
Assignees
Labels
Package: browser Issues related to the Sentry Browser SDK Type: Bug

Comments

@mfb
Copy link

mfb commented May 17, 2024

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/browser

SDK Version

8.2.1

Framework Version

No response

Link to Sentry event

No response

SDK Setup

No response

Steps to Reproduce

I enabled the tunnel option pointing at my tunnel controller, which looks for a dsn property in the first part of the payload. This has always worked fine with v7, and I believe is correct according to the tunnel docs at https://docs.sentry.io/platforms/javascript/troubleshooting/

On v8, the dsn property is missing for INP spans. Seems like this is a bug in v8? Or else, tunnels would need to be modified to work without receiving the "dsn" property.

Expected Result

On v7, the tunnel payload for INP spans looks like this (note the dsn property):

{"sent_at":"2024-05-17T03:57:01.321Z","dsn":"https://foo@ingest.us.sentry.io/bar"}
{"type":"span"}
{"data":{"sentry.origin":"manual","sentry.op":"ui.interaction.click"...

Actual Result

On v8 the tunnel payload is missing the dsn property:

{"sent_at":"2024-05-17T04:04:23.208Z","trace":{"trace_id":"c13cef34cd1248b3917969b9f20c4acb","sample_rate":"1","transaction":"GET /node","public_key":"foo","environment":"prod","sampled":"true"}}
{"type":"span"}
{"data":{"sentry.origin":"manual","sentry.op":"ui.interaction.click"...
@mfb mfb added the Type: Bug label May 17, 2024
@github-actions github-actions bot added the Package: browser Issues related to the Sentry Browser SDK label May 17, 2024
@mydea
Copy link
Member

mydea commented May 17, 2024

hey, thanks for reporting this, we'll look into this - maybe something got lost in translation on the way to v8 there!

@mydea mydea self-assigned this May 17, 2024
mydea added a commit that referenced this issue May 17, 2024
This was forgotten/got lost while we migrated this from v7 to v8. Now,
adding the dsn again when the tunnel is enabled.

Fixes #12094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: browser Issues related to the Sentry Browser SDK Type: Bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants