Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose ESM loader exclude and include in SDK options #12878

Closed
timfish opened this issue Jul 11, 2024 · 0 comments · Fixed by #12910
Closed

Expose ESM loader exclude and include in SDK options #12878

timfish opened this issue Jul 11, 2024 · 0 comments · Fixed by #12910
Assignees
@timfish
Labels
Package: node Issues related to the Sentry Node SDK Type: Improvement

Comments

@timfish
Copy link
Collaborator

timfish commented Jul 11, 2024

Problem Statement

import-in-the-middle now has a means to exclude and include libraries which are incompatible.

Solution Brainstorm

We should expose these to users via SDK init.
@timfish timfish added Type: Improvement Package: node Issues related to the Sentry Node SDK labels Jul 11, 2024
@timfish timfish self-assigned this Jul 11, 2024
@timfish timfish mentioned this issue Jul 14, 2024
Merged
AbhiPrasad pushed a commit that referenced this issue Jul 15, 2024
@timfish
feat: Expose exclude and include options for ESM loader (#12910)
1d3e208 
Closes #12878

I added this feature to `import-in-the-middle` which was released in
v1.9.0:
- nodejs/import-in-the-middle#124

This PR changes the hook from `@opentelemetry/instrumentation/hook.mjs`
to `import-in-the-middle/hook.mjs` as it was only pasing though anyway
and the otel hook doesn't pass the `initialize` export.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timfish timfish

Labels
Package: node Issues related to the Sentry Node SDK Type: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Expose exclude and include options for ESM loader getsentry/sentry-javascript
1 participant
@timfish