Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add amqplibIntegration to Node #13312

Closed
5 tasks
mydea opened this issue Aug 12, 2024 · 1 comment · Fixed by #13714
Closed
5 tasks

Add amqplibIntegration to Node #13312

mydea opened this issue Aug 12, 2024 · 1 comment · Fixed by #13714
Assignees
@obecny
Labels
Meta: Help Wanted Package: node Issues related to the Sentry Node SDK Package-Meta: OpenTelemetry

Comments

@mydea
Copy link
Member

mydea commented Aug 12, 2024 •
edited
Loading

Description

We want to instrument amqplib. There is an existing OTEL instrumentation for this:

https://www.npmjs.com/package/@opentelemetry/instrumentation-amqplib

Tasks
Preview Give feedback

This is a queue integration, and thus must follow https://develop.sentry.dev/sdk/telemetry/traces/modules/queues/. You can see https://docs.sentry.io/platforms/javascript/guides/node/tracing/instrumentation/custom-instrumentation/queues-module/ for a reference.
@mydea mydea mentioned this issue Aug 12, 2024
Closed
@obecny obecny self-assigned this Sep 3, 2024
@AbhiPrasad AbhiPrasad mentioned this issue Sep 19, 2024
Merged
2 tasks
@obecny obecny closed this as completed in de9cf8a Sep 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

A PR closing this issue has just been released 🚀

This issue was closed by PR #13714, which was included in the 8.32.0 release.

@mydea mydea mentioned this issue Sep 26, 2024
Merged
mydea added a commit that referenced this issue Sep 26, 2024
@mydea
ci: Automatically notify issues after release (#13808)
3714d60 
This ensures that whenever we publish a release, we automatically add a
comment to all issues linked to PRs like this:


#13312 (comment)


![image](https://github.com/user-attachments/assets/c84a810f-5653-4fcc-85d0-bc6ad0aa4801)

This way, we do not need to manually go through issues, but users can
automatically be notified that a change should be out now.
@chargome chargome mentioned this issue Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obecny obecny

Labels
Meta: Help Wanted Package: node Issues related to the Sentry Node SDK Package-Meta: OpenTelemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(node): Add amqplibIntegration getsentry/sentry-javascript
2 participants
@obecny @mydea