Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next.js: Pick up clientTraceMetadata in pages router instrumentation #13656

Closed
lforst opened this issue Sep 10, 2024 · 3 comments · Fixed by #14059 or #13889
Closed

Next.js: Pick up clientTraceMetadata in pages router instrumentation #13656

lforst opened this issue Sep 10, 2024 · 3 comments · Fixed by #14059 or #13889
Assignees
@lforst

Comments

@lforst
Copy link
Member

lforst commented Sep 10, 2024 •
edited
Loading

Description

vercel/next.js#69620 is merged and we can pick up the meta tags in the pages router.

Ref: #8105
@lforst lforst self-assigned this Sep 10, 2024
@lforst
Copy link
Member Author

lforst commented Sep 20, 2024 •
edited
Loading

Ok, we need to switch all the pages router instrumentation to OTEL for this to work, because as of now, our traces and the nextjs traces are completely separate, and we are getting a different trace id from nextjs than we do emit ourselves.

This task basically depends on #13737

@lforst
Copy link
Member Author

lforst commented Oct 23, 2024

Will automagically fix-itself with #13889

PR to test #14059

This was referenced Oct 23, 2024
Merged
Merged
lforst added a commit that referenced this issue Oct 28, 2024
@lforst
test(nextjs): Test for client trace propagation with Turbopack (#14059)
ff8e780 
Resolves #13656
@github-actions GitHub Actions
Copy link
Contributor

A PR closing this issue has just been released 🚀

This issue was referenced by PR #13889, which was included in the 8.36.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lforst lforst

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@lforst