-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nuxt] Improve tracing functionality in ESM #13943
Labels
Package: nuxt
Issues related to the Sentry Nuxt SDK
Comments
This was referenced Oct 10, 2024
s1gr1d
added a commit
that referenced
this issue
Oct 14, 2024
s1gr1d
added a commit
that referenced
this issue
Oct 17, 2024
BREAKING CHANGE: The `--import` flag must not be added anymore. If it is still set, the server-side will be initialized twice and this leads to unexpected errors. --- First merge this: #13945 Part of this: #13943 This PR makes it the default to include a rollup plugin that wraps the server entry file with a dynamic import (`import()`). This is a replacement for the node `--import` CLI flag. If you still want to manually add the CLI flag you can use this option in the `nuxt.config.ts` file: ```js sentry: { dynamicImportForServerEntry: false, } ``` (option name is up for discussion)
Closing this as all PRs are merged |
billyvg
pushed a commit
that referenced
this issue
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Problem Statement
Currently, you have to add the Sentry server config from the build output to the
--input
parameter of your node script like this:The
--import
CLI flag makes it possible to preload a module. The server config file needs to be added with the--import
flag as Sentry needs to be loaded before other modules to register a hook internally:sentry-javascript/packages/node/src/sdk/initOtel.ts
Line 68 in 86c626e
However, this needs extra configuration from the user-side and it makes the deployment setup more complicated (as different deployment providers have a different feature set and most don't fully support modification of the
node
run script).Solution
The internally discussed idea is to wrap the server entry file with a dynamic import (
import()
), as this also runs the code after everything else (see here).This would change the output from this:
to this:
Tasks
import()
feat(nuxt): Add Rollup plugin to wrap server entry withimport()
#13945--import
flag feat(nuxt): Make dynamic import() wrapping default #13958The text was updated successfully, but these errors were encountered: