-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Identifier '$haml' has already been declared #13982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey @florian-lefebvre, thanks for reaching out. Can you add |
The error seems to occur super early, here is what I get: ➜ satquiz git:(renovate/major-sentry-javascript-monorepo) ✗ pnpm astro dev
> satquiz@0.0.1 astro /home/florian/Documents/github/satquiztime/satquiz
> astro "dev"
09:07:19 [@sentry/astro] Using /home/florian/Documents/github/satquiztime/satquiz/sentry/client.ts for client init.
09:07:19 [@sentry/astro] Using /home/florian/Documents/github/satquiztime/satquiz/sentry/server.ts for server init.
09:07:19 [WARN] [config] The adapter @astrojs/netlify provides experimental support for "assets". You may experience issues or breaking changes until this feature is fully supported by the adapter.
09:07:19 [WARN] [config] The adapter @astrojs/netlify provides experimental support for "astro:env getSecret". You may experience issues or breaking changes until this feature is fully supported by the adapter.
09:07:19 [types] Generated 2ms
astro v4.16.3 ready in 742 ms
┃ Local http://localhost:4321/
┃ Network use --host to expose
09:07:20 watching for file changes...
09:07:33 [ERROR] Identifier '$haml' has already been declared
Stack trace:
at compileSourceTextModule (node:internal/modules/esm/utils:339:16)
at callTranslator (node:internal/modules/esm/loader:428:14)
at async link (node:internal/modules/esm/module_job:87:21) The error only occurs once I open |
@florian-lefebvre astro build runs successfully? Are you using any UI framework integration within astro? |
The project has many dependencies so many things could conflict. I guess I'll have to go little by little, disabling things until it starts working to spot the issue. Thanks anyways! |
@florian-lefebvre Keep us posted here please if you spot the culprit 🙏 |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
@chargome I managed to reproduce the issue, here is a minimal reproduction: https://stackblitz.com/edit/github-lmarqdw6?file=astro.config.mjs,src%2Fpages%2Findex.astro&on=stackblitz. TLDR:
|
@florian-lefebvre Any resolution for this on your end? |
No I have not upgraded the sentry integration |
This should already be fixed in version 9 (which is released this week). I fixed it for v8: #15352 (probably released with 8.55.0) |
Makes sure that `vue` is not wrapped and users don't get the error `$haml has already been declared` closes #13982
Awesome, can't wait to try this! Is there any way to subscribe to the release of v8.55? |
If you want you can already update to version v9 (it's released now). You cannot subscribe but our release bot (or me) will comment on this issue once the fix is released to v8. |
Thanks @s1gr1d . My company is running an SSR app with Vue and an Express server. We utilize registerEsmLoaderHooks: {
exclude: [/vue/],
}, That seems to resolve our issue as well. |
#15352 released with 8.55.0 |
Is there an existing issue for this?
How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using?
@sentry/astro
SDK Version
8.34.0
Framework Version
8.34.0
Link to Sentry event
No response
Reproduction Example/SDK Setup
Hi! I'm trying to upgrade the Astro integration from
7.119.2
to8.34.0
(also tried from7.119.2
to8.0.0
and same). I've tried to create a minimal reproduction to isolate this issue, but I can't manage to reproduce the error in a brand new project. I apogolize about this, I know it sucks as a maintainer not to get a minimal repro.So this issue is first to ask for clues to debug the error, and 2nd to provide a proper minimal reproduction after debugging. There's one related issue at #13304 for Nuxt but it seems unrelated to my setup.
The issue occurs with a minimal setup, ie.
pnpm astro add @sentry/astro
:The error goes away if I remove sentry from the integrations array.
Steps to Reproduce
astro dev
Expected Result
The page should load properly
Actual Result
I get the following error:
The text was updated successfully, but these errors were encountered: