Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback dialog header does not wrap with long titles #14351

Closed
billyvg opened this issue Nov 18, 2024 · 1 comment · Fixed by #14355
Closed

Feedback dialog header does not wrap with long titles #14351

billyvg opened this issue Nov 18, 2024 · 1 comment · Fixed by #14355
Labels
Feature: User Feedback

Comments

@billyvg
Copy link
Member

billyvg commented Nov 18, 2024

Discussed in #14339

Originally posted by AgarkovRoman November 18, 2024
I am migrating from v7 to v8, and there is an issue with the feedback dialog.
If the title is too long, the dialog becomes oversized, and there are no built-in CSS variables to control it.
Screenshot 2024-11-18 at 12 15 30

Here is how it looked in the previous version with the same CSS styles.
Screenshot 2024-11-18 at 12 15 40

Am I missing something, or do you have any ideas on how to fix it? Thanks!
@billyvg billyvg mentioned this issue Nov 19, 2024
Merged
billyvg added a commit that referenced this issue Nov 21, 2024
@billyvg
fix(feedback): Fix non-wrapping form title (#14355)
85daf90 
Fixes an issue with long form titles causing the width of the dialog to
expand. Instead, apply the css var `--form-width` to the dialog contents
so that the title wraps.

After:
<img width="323" alt="image"
src="https://github.com/user-attachments/assets/b2982b72-e9df-4459-8241-4b47f2fdd4fe">

 
<img width="558" alt="image"
src="https://github.com/user-attachments/assets/cd4a2285-7088-4bc1-b628-9672861a71f2">

Single line:
<img width="344" alt="image"
src="https://github.com/user-attachments/assets/1661ca0d-8cea-435c-86a8-cc56913d0483">


Closes #14351
@github-actions GitHub Actions
Copy link
Contributor

A PR closing this issue has just been released 🚀

This issue was referenced by PR #14355, which was included in the 8.40.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature: User Feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(feedback): Fix non-wrapping form title getsentry/sentry-javascript
1 participant
@billyvg