Skip to content

Extract profiling node bindings into separate package #14432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mydea opened this issue Nov 22, 2024 · 0 comments · Fixed by #15208
Closed

Extract profiling node bindings into separate package #14432

mydea opened this issue Nov 22, 2024 · 0 comments · Fixed by #15208
Labels
Package: profiling-node Issues related to the Sentry Profiling Node SDK

Comments

@mydea
Copy link
Member

mydea commented Nov 22, 2024

Proposal

Today, we build the profiling node bindings in this repo, on each release (and in many PRs etc). Building these takes quite some time (up to 30 minutes), and can be pretty flaky, especially building the windows bindings. This slows down development and releases significantly.

What if, instead, we'd extract the native code & bindings part out of the monorepo, into a separate package? Then this package could be released separately, invoking cost of building & running these things only when the native code actually changes.

The @sentry/profiling-node package could remain in the monorepo and simply depend on the bindings package, e.g. @sentry-internal/profiling-node-bindings or something along these lines.

Disclaimer

I am by far not an expert on how the profiling-node package works, and maybe this is not possible at all. But something along these lines would be a good direction to go IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: profiling-node Issues related to the Sentry Profiling Node SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants