Skip to content

Rewrite google-cloud-serverless tests to avoid using domains #14769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mydea opened this issue Dec 18, 2024 · 1 comment
Closed

Rewrite google-cloud-serverless tests to avoid using domains #14769

mydea opened this issue Dec 18, 2024 · 1 comment
Labels
Meta: Good First Issue Package: google-cloud-serverless Issues related to the Sentry GCP Serverless SDK Type: Tests

Comments

@mydea
Copy link
Member

mydea commented Dec 18, 2024

Description

They are deprecated in Node 18, so we should rewrite these tests.
@mydea mydea mentioned this issue Dec 18, 2024
Merged
GrizliK1988 added a commit to GrizliK1988/sentry-javascript that referenced this issue Jan 4, 2025
@GrizliK1988
test(google-cloud): Replace error handling using node domain (getsent…
b36c00e 
…ry#14769)

Replace error handling using deprecated node:domain in google-cloud-serverless tests

Fixes getsentry#14769
@GrizliK1988 GrizliK1988 mentioned this issue Jan 4, 2025
Merged
2 tasks
GrizliK1988 added a commit to GrizliK1988/sentry-javascript that referenced this issue Jan 7, 2025
@GrizliK1988
test(google-cloud): Replace error handling using node domain (getsent…
de02754 
…ry#14769)

Replace error handling using deprecated node:domain in google-cloud-serverless tests

Fixes getsentry#14769
GrizliK1988 added a commit to GrizliK1988/sentry-javascript that referenced this issue Jan 7, 2025
@GrizliK1988
test(google-cloud): Replace error handling using node domain (getsent…
915fe0e 
…ry#14769)

Replace error handling using deprecated node:domain in google-cloud-serverless tests

Fixes getsentry#14769
GrizliK1988 added a commit to GrizliK1988/sentry-javascript that referenced this issue Jan 13, 2025
@GrizliK1988
test(google-cloud): Replace error handling using node domain (getsent…
01b1e09 
…ry#14769)

Replace error handling using deprecated node:domain in google-cloud-serverless tests

Fixes getsentry#14769
GrizliK1988 added a commit to GrizliK1988/sentry-javascript that referenced this issue Jan 13, 2025
@GrizliK1988
test(google-cloud): Replace error handling using node domain (getsent…
e5c096b 
…ry#14769)

Replace error handling using deprecated node:domain in google-cloud-serverless tests

Fixes getsentry#14769
@AbhiPrasad
Copy link
Member

fixed by #14908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Meta: Good First Issue Package: google-cloud-serverless Issues related to the Sentry GCP Serverless SDK Type: Tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mydea @AbhiPrasad