Sentry span not keep traceId

[xiaoxiangmoe]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/node

SDK Version

8.43.0

Framework Version

nodejs

Link to Sentry event

No response

Reproduction Example/SDK Setup

No response

Steps to Reproduce

import * as _crypto from 'node:crypto';
import * as Sentry from '@sentry/node';

// Simulates the traceId obtained from the outside world
function getRandomSentryTraceData() {
    const sentryTrace = _crypto.randomBytes(16).toString('hex') + '-' + _crypto.randomBytes(8).toString('hex');
    console.log('traceId', sentryTrace);
    return { sentryTrace, baggage: 'environment=dev' };
}

const main = () =>
    Sentry.continueTrace(getRandomSentryTraceData(), async () => {
      await Sentry.startSpan({ name: 'hello span' }, (span) => {
          console.log('span traceId', span.spanContext().traceId);
      })
  })

main()

Expected Result

Log same traceId

same as v8.42.0

Actual Result

different traceId

[Lms24]

Hi @xiaoxiangmoe thanks for writing in! This is probably related to what we initially discovered in #14787. We're working on a fix

EDIT: It is probably not related after all

[Lms24]

@xiaoxiangmoe just to confirm: Are you calling Sentry.init()? Please post your init code and how you initialize the SDK (e.g. via --import instrument.mjs).

[andreiborza]

@xiaoxiangmoe I set this up as a repo here: https://github.com/andreiborza/14803-continue-trace

Are there any differences to what you have? Could you try running this and see if it runs as expected?

I'm getting

$ node --import ./instrument.mjs index.js
trace data traceId = 2dbc91a35572b1dea31563396f615511
span       traceId = 2dbc91a35572b1dea31563396f615511

[xiaoxiangmoe]

@andreiborza change

https://github.com/andreiborza/14803-continue-trace/blob/c9b0bbf05be0feb0dbdbbbe0647dfe77dd7afb74/index.js#L2

from

import * as Sentry from '@sentry/node';

to

import * as Sentry from '@sentry/core';

will make this error happen

---

Okay, I found why it it not work.

In my real world app, it exists both

import * as Sentry from '@sentry/node';

Sentry.startSpan()

and

// for sharing code to both node and browser, we import @sentry/core here
import * as Sentry from '@sentry/core';

Sentry.startSpan()

And @sentry/node and @sentry/core have different Sentry.startSpan implementation since 8.43.0

[xiaoxiangmoe]

#14819 may fix this

[andreiborza]

@xiaoxiangmoe yep, that's likely it. Thanks for raising this tho.