fix(v8/core): Use consistent continueTrace implementation in core
#14819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…14813) We have a different implementation of `continueTrace` for OTEL/Node. Until now we relied on actually using the import from `@sentry/node` vs `@sentry/core` to ensure this. However, this is a footgun, and actually lead to a problem in NextJS because we used the core variant there. Also, it is simply not isomorphic. So to fix this, this PR puts `continueTrace` on the ACS so we can consistently use the core variant in all environments. Fixes #14787
size-limit report 📦
|
3 tasks
andreiborza
approved these changes
Dec 20, 2024
Lms24
approved these changes
Dec 23, 2024
mydea
approved these changes
Dec 30, 2024
alexandresoro
pushed a commit
to alexandresoro/ouca-backend
that referenced
this pull request
Jan 7, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@sentry/node](https://github.com/getsentry/sentry-javascript/tree/master/packages/node) ([source](https://github.com/getsentry/sentry-javascript)) | dependencies | minor | [`8.47.0` -> `8.48.0`](https://renovatebot.com/diffs/npm/@sentry%2fnode/8.47.0/8.48.0) | | [@sentry/react](https://github.com/getsentry/sentry-javascript/tree/master/packages/react) ([source](https://github.com/getsentry/sentry-javascript)) | dependencies | minor | [`8.47.0` -> `8.48.0`](https://renovatebot.com/diffs/npm/@sentry%2freact/8.47.0/8.48.0) | --- ### Release Notes <details> <summary>getsentry/sentry-javascript (@​sentry/node)</summary> ### [`v8.48.0`](https://github.com/getsentry/sentry-javascript/releases/tag/8.48.0) [Compare Source](getsentry/sentry-javascript@8.47.0...8.48.0) ##### Deprecations - **feat(v8/core): Deprecate `getDomElement` method ([#​14799](getsentry/sentry-javascript#14799 Deprecates `getDomElement`. There is no replacement. ##### Other changes - fix(nestjs/v8): Use correct main/module path in package.json ([#​14791](getsentry/sentry-javascript#14791)) - fix(v8/core): Use consistent `continueTrace` implementation in core ([#​14819](getsentry/sentry-javascript#14819)) - fix(v8/node): Correctly resolve debug IDs for ANR events with custom appRoot ([#​14823](getsentry/sentry-javascript#14823)) - fix(v8/node): Ensure `NODE_OPTIONS` is not passed to worker threads ([#​14825](getsentry/sentry-javascript#14825)) - fix(v8/angular): Fall back to element `tagName` when name is not provided to `TraceDirective` ([#​14828](getsentry/sentry-javascript#14828)) - fix(aws-lambda): Remove version suffix from lambda layer ([#​14843](getsentry/sentry-javascript#14843)) - fix(v8/node): Ensure express requests are properly handled ([#​14851](getsentry/sentry-javascript#14851)) - feat(v8/node): Add `openTelemetrySpanProcessors` option ([#​14853](getsentry/sentry-javascript#14853)) - fix(v8/react): Use `Set` as the `allRoutes` container. ([#​14878](getsentry/sentry-javascript#14878)) ([#​14884](getsentry/sentry-javascript#14884)) - fix(v8/react): Improve handling of routes nested under path="/" ([#​14897](getsentry/sentry-javascript#14897)) - feat(v8/core): Add `normalizedRequest` to `samplingContext` ([#​14903](getsentry/sentry-javascript#14903)) - fix(v8/feedback): Avoid lazy loading code for `syncFeedbackIntegration` ([#​14918](getsentry/sentry-javascript#14918)) Work in this release was contributed by [@​arturovt](https://github.com/arturovt). Thank you for your contribution! ##### Bundle size 📦 | Path | Size | | ---------------------------------------------------------------- | ----------------- | | [@​sentry/browser](https://github.com/sentry/browser) | 23.29 KB | | [@​sentry/browser](https://github.com/sentry/browser) - with treeshaking flags | 21.96 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing) | 35.85 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) | 73.09 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) - with treeshaking flags | 63.48 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay with Canvas) | 77.4 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay, Feedback) | 89.34 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. Feedback) | 39.5 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. sendFeedback) | 27.89 KB | | [@​sentry/browser](https://github.com/sentry/browser) (incl. FeedbackAsync) | 32.69 KB | | [@​sentry/react](https://github.com/sentry/react) | 25.96 KB | | [@​sentry/react](https://github.com/sentry/react) (incl. Tracing) | 38.66 KB | | [@​sentry/vue](https://github.com/sentry/vue) | 27.56 KB | | [@​sentry/vue](https://github.com/sentry/vue) (incl. Tracing) | 37.69 KB | | [@​sentry/svelte](https://github.com/sentry/svelte) | 23.45 KB | | CDN Bundle | 24.49 KB | | CDN Bundle (incl. Tracing) | 37.56 KB | | CDN Bundle (incl. Tracing, Replay) | 72.75 KB | | CDN Bundle (incl. Tracing, Replay, Feedback) | 78.11 KB | | CDN Bundle - uncompressed | 71.93 KB | | CDN Bundle (incl. Tracing) - uncompressed | 111.42 KB | | CDN Bundle (incl. Tracing, Replay) - uncompressed | 225.5 KB | | CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed | 238.6 KB | | [@​sentry/nextjs](https://github.com/sentry/nextjs) (client) | 38.92 KB | | [@​sentry/sveltekit](https://github.com/sentry/sveltekit) (client) | 36.36 KB | | [@​sentry/node](https://github.com/sentry/node) | 162.8 KB | | [@​sentry/node](https://github.com/sentry/node) - without tracing | 98.94 KB | | [@​sentry/aws-serverless](https://github.com/sentry/aws-serverless) | 126.63 KB | </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45Mi4wIiwidXBkYXRlZEluVmVyIjoiMzkuOTIuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/454 Reviewed-by: Alexandre Soro <code@soro.dev> Co-authored-by: renovate <renovate@git.tristess.app> Co-committed-by: renovate <renovate@git.tristess.app>
This was referenced Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 backport of #14813
We have a different implementation of
continueTracefor OTEL/Node. Until now we relied on actually using the import from@sentry/nodevs@sentry/coreto ensure this. However, this is a footgun, and actually lead to a problem in NextJS because we used the core variant there. Also, it is simply not isomorphic.So to fix this, this PR puts
continueTraceon the ACS so we can consistently use the core variant in all environments.Fixes #14787