Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract node-fetch non-span functionality into standalone instrumentation #15212

Closed
mydea opened this issue Jan 29, 2025 · 1 comment · Fixed by #15231
Closed

Extract node-fetch non-span functionality into standalone instrumentation #15212

mydea opened this issue Jan 29, 2025 · 1 comment · Fixed by #15231

Comments

@mydea
Copy link
Member

mydea commented Jan 29, 2025

Description

Today, we still rely on adding the @opentelemetry/instrumentation-undici for all users, even if they have performance disabled.

We should change this like we already did for http here: #13763

So that we have our own instrumentation, that registers our own diagnostics channel stuff, to ensure we have 1. trace propagation 2. breadcrumbs. This way, we can stop adding the instrumentation-undici instrumentation from OTEL, reducing one more dependency/potential for conflict.
This was referenced Jan 29, 2025
Open
Merged
@github-actions GitHub Actions
Copy link
Contributor

A PR closing this issue has just been released 🚀

This issue was referenced by PR #15231, which was included in the 9.1.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(node): Extract Sentry-specific node-fetch instrumentation getsentry/sentry-javascript
1 participant
@mydea