Skip to content

Fix Express v5 instrumentation handling of 404 routes #16210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mydea opened this issue May 6, 2025 · 1 comment · Fixed by #16211
Closed

Fix Express v5 instrumentation handling of 404 routes #16210

mydea opened this issue May 6, 2025 · 1 comment · Fixed by #16211
Assignees
@mydea

Comments

@mydea
Copy link
Member

mydea commented May 6, 2025

Description

404 routes should not have a 'http.route': '/' attribute, but instead no route attribute.
@mydea mydea mentioned this issue May 6, 2025
Merged
@mydea mydea self-assigned this May 6, 2025
mydea added a commit that referenced this issue May 7, 2025
@mydea
fix(node): Fix 404 route handling in express 5 (#16211)
e0c0d9d 
Closes #16210
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025

A PR closing this issue has just been released 🚀

This issue was referenced by PR #16211, which was included in the 9.16.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(node): Fix 404 route handling in express 5 getsentry/sentry-javascript
1 participant
@mydea