Typing question for the "requestHandler" function in "sentry-javascript/packages/node/src/handlers.ts"

[pgmystery]

• Review the documentation: https://docs.sentry.io/
• Search for existing issues: https://github.com/getsentry/sentry-javascript/issues
• Use the latest release: https://github.com/getsentry/sentry-javascript/releases
• Provide a link to the affected event from your Sentry account

Package + Version

• @sentry/browser
• @sentry/node
• raven-js
• raven-node (raven for node)
• other:

Version:

5.12.3

Description

The function "parseRequest" from "sentry-javascript/packages/node/src/handlers.ts" supports for options -> request a boolean or string array. But the "requestHandler" function in the same file, only supports boolean for options -> request. Is there a reason why the "requestHandler" doesn't include the string array in the typings ?

export function parseRequest( event: Event, req: { [key: string]: any; }, options?: { request?: boolean | string[]; },

export function requestHandler(options?: { request?: boolean; }): (req: http.IncomingMessage, res: http.ServerResponse, next: (error?: any) => void) => void {

[kamilogorek]

@pgmystery it was a bug, fixed in #2433
Thanks!