Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve incorrect ParseRequest typing #2433

Merged
merged 1 commit into from
Feb 17, 2020
Merged

fix: Improve incorrect ParseRequest typing #2433

merged 1 commit into from
Feb 17, 2020

Conversation

kamilogorek
Copy link
Contributor

Fixes #2424

@kamilogorek kamilogorek mentioned this pull request Feb 17, 2020
Closed
9 tasks
@getsentry-bot
Copy link
Contributor

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖 ✅ TSLint passed
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 16.7305 kB) (ES6: 15.7402 kB)

Generated by 🚫 dangerJS against 959f7ce

lobsterkatie
lobsterkatie approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kamilogorek kamilogorek merged commit 3fed200 into master Feb 17, 2020
@kamilogorek kamilogorek deleted the parse-request-typing branch February 17, 2020 09:48
This was referenced Mar 14, 2020
Merged
Merged
Merged
Closed
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobsterkatie lobsterkatie lobsterkatie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typing question for the "requestHandler" function in "sentry-javascript/packages/node/src/handlers.ts"
3 participants
@kamilogorek @getsentry-bot @lobsterkatie