Skip to content

Please follow SemVer when publishing versions #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
okonet opened this issue Sep 3, 2014 · 3 comments
Closed

Please follow SemVer when publishing versions #256

okonet opened this issue Sep 3, 2014 · 3 comments

Comments

@okonet
Copy link

okonet commented Sep 3, 2014

v1.1.16 breaks API in comparison to v1.1.11

Compare: https://github.com/getsentry/raven-js/blob/1.1.11/src/raven.js#L279 vs https://github.com/getsentry/raven-js/blob/1.1.16/src/raven.js#L280

This should not happen in patch version but in a major one so the builds using npm or other package managers doesn't break.

@mattrobenolt
Copy link
Contributor

Thanks, but you missed the deprecation: https://github.com/getsentry/raven-js/blob/1.1.16/src/raven.js#L329 I didn't break anything.

@okonet
Copy link
Author

okonet commented Sep 3, 2014

The problem is that the API docs are for the version 1.1.16, where the setUserContext method is documented. If you'll install a version from npm, it will throw an error.

@mattrobenolt
Copy link
Contributor

So don't install it from npm. Not sure what you're asking me to do. Would you like to me to update the documentation? The code is not an issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants