Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In React-Native document gets set sometimes without a location object #800

Closed
rmevans9 opened this issue Dec 14, 2016 · 1 comment
Closed

Comments

@rmevans9
Copy link
Contributor

This is a bug in TraceKit but not sure which TraceKit repository the file stored in this repo is pulled from.

Currently in my React Native app document gets set by one of the libraries used (not sure which.... just know it does with just a single property on the object). When an exception occurs and raven attempts to log that error out to Sentry (or wherever it is setup to log) the logging of the error blows up as well.

I would expect that it can handle the document object not having a location property.

The fix is to modify https://github.com/getsentry/raven-js/blob/master/vendor/TraceKit/tracekit.js#L27 to be more tolerant to the location property being undefined. I can submit a PR but want to figure out which repo that fix really should go into so that it propagates to this project so that I can start logging errors in React Native correctly.

@mattrobenolt
Copy link
Contributor

We have our own fully vendored and highly modified version of TraceKit that we use internally, so if you'd like to submit a PR, this is the best place. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants