@sentry/* 7.68.0 breaks @sentry/profiling-node latest

[tomgrossman]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/node

SDK Version

@sentry/* - 7.68.0, @sentry/profiling-node - 1.2.1
Works fine with versions 7.67.0

Framework Version

Node 18.12.1 Nest.js 10.1.17

Link to Sentry event

No response

SDK Setup

import * as Sentry from '@sentry/node';
import * as Tracing from '@sentry/tracing';
import { RewriteFrames } from '@sentry/integrations';
import { ProfilingIntegration } from '@sentry/profiling-node';

Sentry.init({
    dsn: '...',
    environment: '...',
    integrations: [
      new RewriteFrames({
        root: '/app',
      }),
      new Sentry.Integrations.Http({ tracing: true }),
      new Tracing.Integrations.Express({
        app: httpAdapter.getInstance(),
      }),
      new ProfilingIntegration(),
    ],
    tracesSampler: (samplingContext) => {
      if (samplingContext.request?.url?.includes('/health')) {
        return 0;
      }

      return 0.2;
    },
    profilesSampleRate: 1.0,
  });

Steps to Reproduce

1. install latest @sentry versions
2. integrate @sentry/profiling-node
3. build

Expected Result

build successfully :)

Actual Result

Error thrown during nest build:

Type 'ProfilingIntegration' is not assignable to type 'Integration'.
  Types of property 'setupOnce' are incompatible.

Works fine with versions 7.67.0

[Lms24]

Hey @tomgrossman which TypeScript version are you using? Just wondering if this is related to #8954

[tomgrossman]

Hey @tomgrossman which TypeScript version are you using? Just wondering if this is related to #8954

@Lms24
"typescript": "^5.2.2"

[Lms24]

I tried to reproduce this with a barebones Node + Typescript app and couldn't get the type error. It's a little weird because we didn't change anything in the Integration interface lately, especially not between 7.67.0 and 7.68.0. Here's my repro: https://github.com/Lms24/gh-sentry-javascript-8965-node-integration-type-error please take a look and let me know what to change to reproduce this. Alternatively, feel free to provide your own repro app that we can use to look into this further.

Before you get started though, it might be worthwhile to check for version mismatches:

• Check if your lock file contains any @sentry/ packages (other than profiling-node) that are not aligned with version 7.68.0. If so, please upgrade them.
• Similarly, have you tried deleting node_modules and reinstalling your deps? Maybe something is off...
• To avoid version mismatches you can also get rid of the @sentry/tracing package which is not needed anymore. Everything from tracing is now exported from @sentry/node. See https://docs.sentry.io/platforms/node/guides/express/#monitor-performance