Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils.js vs inline helper functions #941

Closed
LewisJEllis opened this issue Apr 26, 2017 · 3 comments
Closed

utils.js vs inline helper functions #941

LewisJEllis opened this issue Apr 26, 2017 · 3 comments

Comments

@LewisJEllis
Copy link
Contributor

LewisJEllis commented Apr 26, 2017

We have ~15 util/helper functions inlined together in raven.js here (and exported for testing here), but then we also have utils.js with just two util/helper functions.

These utils are sufficiently similar that they ought to live together; we should either move most of the ones in raven.js out to utils.js, or bring the utils.js ones into raven.js and get rid of utils.js. Weak pref for the former, but don't care too much, just want to get rid of inconsistency.

@LewisJEllis LewisJEllis changed the title utils vs inline helper functions utils.js vs inline helper functions Apr 26, 2017
@captbaritone
Copy link
Contributor

I think it would be best to move everything into raven.js. I can work on this.

@LewisJEllis
Copy link
Contributor Author

Hey @captbaritone, appreciate the comment & offer but you might hold off a bit; this isn't too pressing and we've had some minor internal discussion on this that just hasn't yet made it to a decision/follow-up comment yet, mainly because the question of "what about pieces that could be shared between here and raven-node" also plays into this.

@captbaritone
Copy link
Contributor

Cool. I'll hold off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants