You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have ~15 util/helper functions inlined together in raven.js here (and exported for testing here), but then we also have utils.js with just two util/helper functions.
These utils are sufficiently similar that they ought to live together; we should either move most of the ones in raven.js out to utils.js, or bring the utils.js ones into raven.js and get rid of utils.js. Weak pref for the former, but don't care too much, just want to get rid of inconsistency.
The text was updated successfully, but these errors were encountered:
LewisJEllis
changed the title
utils vs inline helper functions
utils.js vs inline helper functions
Apr 26, 2017
Hey @captbaritone, appreciate the comment & offer but you might hold off a bit; this isn't too pressing and we've had some minor internal discussion on this that just hasn't yet made it to a decision/follow-up comment yet, mainly because the question of "what about pieces that could be shared between here and raven-node" also plays into this.
We have ~15 util/helper functions inlined together in raven.js here (and exported for testing here), but then we also have utils.js with just two util/helper functions.
These utils are sufficiently similar that they ought to live together; we should either move most of the ones in raven.js out to utils.js, or bring the utils.js ones into raven.js and get rid of utils.js. Weak pref for the former, but don't care too much, just want to get rid of inconsistency.
The text was updated successfully, but these errors were encountered: