ref: Move utils from raven.js to utils.js file #1084
Conversation
|
|
||
| var isError = utils.isError, | ||
| isObject = utils.isObject; | ||
| var utils = require('./utils'); |
There was a problem hiding this comment.
I didn't want to change all instances to utils.something in the codebase, but rather just pull them out like this to make this PR "easier" to digest.
|
FWIW, I explicitly inlined these to improve minified filesize (a few %, but every bit counts). You're welcome to change it, but know that it was done deliberately, and will have an impact. Aside, we should verify minified filesize stays within a certain threshold as part of CI. That threshold can change, of course, but it will require you to manually bump it to "sign off" when increasing it. I basically want to make sure we don't forget about it. |
|
I'm already on it here – #1089 If it'll ever become an issue, we can use rollup to bundle without browserify's overhead. |
Closes #941