Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add bundlesize check to Travis #1089

Merged
merged 3 commits into from
Oct 12, 2017
Merged

ci: Add bundlesize check to Travis #1089

merged 3 commits into from
Oct 12, 2017

Conversation

kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek commented Oct 11, 2017 •
edited
Loading

Still need to find out how to add nice status like this

@kamilogorek kamilogorek requested a review from a team October 11, 2017 11:58
@kamilogorek kamilogorek mentioned this pull request Oct 11, 2017
Merged
MaxBittker
MaxBittker approved these changes Oct 11, 2017
View reviewed changes
Copy link
Contributor

@MaxBittker MaxBittker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good first step, would love to see a graph someday, maybe via zeus? (would also be fun to backfill this data, but not important)

@MaxBittker
Copy link
Contributor

oh yeah, seems like you need creds or something to fix the status and travis

@benvinegar
Copy link
Contributor

👍

@kamilogorek
Copy link
Contributor Author

I removed the token as there are still some issues with providing GH statuses, as they require some funky permissions.

siddharthkp/bundlesize#93
siddharthkp/bundlesize#148

Running it through TravisCI should be good for now.

Done, without errors.
 WARN  github token not found
    You are missing out on some cool features.
    Read more here: https://github.com/siddharthkp/bundlesize#2-build-status
   
 PASS  ./dist/raven.min.js: 9.74KB < maxSize 10KB gzip

@kamilogorek kamilogorek merged commit 742bf2f into master Oct 12, 2017
@kamilogorek kamilogorek deleted the bundlesize branch October 12, 2017 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxBittker MaxBittker MaxBittker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamilogorek @MaxBittker @benvinegar