-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Feedback: Show better message if submission was rejected due to allowedDomains
#9856
Comments
Seems to work now..weird. Maybe the allowed domains took a while to kick in. I would appreciate though if the error message was a little more descriptive and this was easier to debug, leaving the ticket open because of that. If you'd rather have me make a new one just for that, please let me know. |
We'll take a look and see if it's allowed domains related. |
allowedDomains
We could maybe show a different error message if we get a 403 response with this body:
|
I think anything that points the user into the right direction would help, if you can be sure, why not add something like "Are you sure you have added this domain to the list of allowed domains?" |
I currently have this exact problem, my requests failed with a 403 code but I did not know why Then I saw that the response had: This sent me into the wrong direction as I spent time on figuring out why CORS would be a problem After a while I remembered I had made changes to the allowed domain list, so I set the list back to '*' and then everything worked, so I figured out the problem is my allowed domains list, however I have no clue which domain is causing the problem So a message like: "request blocked because domain XY is not in the allowed list", would help a lot |
Thanks @chrisweb, it's on our list. |
If the domain is not in `Allowed Domains` in the Sentry project settings, it would cause a 403 error. The default setting is `*` so this only occurs when the user changes these settings. Fixes #9856
If the domain is not in `Allowed Domains` in the Sentry project settings, it would cause a 403 error. The default setting is `*` so this only occurs when the user changes these settings. Fixes getsentry#9856
Is there an existing issue for this?
How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using?
@sentry/nextjs
SDK Version
7.86.0
Framework Version
Next ^14.0.4
Link to Sentry event
No response
SDK Setup
Steps to Reproduce
Expected Result
Feedback gets sent
Actual Result
Error: There was a problem submitting feedback, please wait and try again.
Sadly also nothing in the console that would help me debug. I tested this locally and on a vercel preview deploy.
I have Early Adopter enabled:
And I do have Vercel previews and localhost in the allowed domains:
The text was updated successfully, but these errors were encountered: